Fix bug with az containerapp create#144
Fix bug with az containerapp create#144StrawnSC merged 2 commits intocalvinsID:containerapp-0.3.10from
az containerapp create#144Conversation
StrawnSC
requested review from
calvinsID,
panchagnula and
runefa
as code owners
| disable_warnings=False, | ||
| user_assigned=None, | ||
| registry_identity=None): | ||
| if image and "/" in image and not registry_server: |
There was a problem hiding this comment.
@StrawnSC I would assume this was added in first place for a reason - would there be any issues with removing this - that might need to be handled separately.
There was a problem hiding this comment.
No, this was a last-minute change that we made in the last version because we thought it would make the user experience better. We had the faulty assumption that the user would always want to set a registry server value if they pass in an image
There was a problem hiding this comment.
For context, all our testing of the MSI feature for az containerapp create involved using ACR registries like so:
az containerapp create --image sstrawn.azurecr.io/image:tag --registry-server sstrawn.azurecr.io
Based on that usage of the create command, it seemed like we could easily help the user our by trying to parse out the registry server from the --image value. For anonymous registries, the user doesn't need to add the --registry-server value, so this feature broke that use case
|
This looks good - only ask like we discussed is to add a test for anonymous registries so we can catch any issues in our testing. |
2 participants
Fixes Azure#5253
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json.